Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rtd): include DFN specification in dev docs #1948

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jul 15, 2024

Include the DFN specification markdown document in the RTD developer docs section. Includes some minor touchup to the document: expand intro, fix headers for table of contents rendering, turn the attribute list into a formatted table, add some explication.


Checklist of items for pull request

  • Replaced section above with description of pull request
  • Removed checklist items not relevant to this pull request

@wpbonelli wpbonelli added the documentation Documentation changes label Jul 15, 2024
@wpbonelli wpbonelli marked this pull request as ready for review July 15, 2024 17:33
@wpbonelli wpbonelli marked this pull request as draft July 17, 2024 22:28
@wpbonelli wpbonelli marked this pull request as ready for review November 12, 2024 12:48
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few minor things, but overall this looks great. I like the new organization.

doc/mf6io/mf6ivar/readme.md Outdated Show resolved Hide resolved
doc/mf6io/mf6ivar/readme.md Show resolved Hide resolved
doc/mf6io/mf6ivar/readme.md Outdated Show resolved Hide resolved
doc/mf6io/mf6ivar/readme.md Outdated Show resolved Hide resolved
doc/mf6io/mf6ivar/readme.md Outdated Show resolved Hide resolved
@wpbonelli wpbonelli merged commit 67e8128 into MODFLOW-USGS:develop Nov 12, 2024
25 of 26 checks passed
@wpbonelli wpbonelli deleted the rtd branch November 12, 2024 15:57
jdhughes-usgs pushed a commit to jdhughes-usgs/modflow6 that referenced this pull request Nov 12, 2024
Include the DFN specification markdown document in the RTD developer docs section. Includes some minor touchup to the document: expand intro, fix headers for table of contents rendering, turn the attribute list into a formatted table, add some explication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants