docs(prt): fix PRP package parameter descriptions #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description of RELEASE_TIME_TOLERANCE and RELEASE_TIME_FREQUENCY failed to mention that these are real numbers, and did not describe epsilon as machine precision. Moreover the default RELEASE_TIME_TOLERANCE was incorrectly stated to be epsilon times 10^9, where in fact it is epsilon times 10^11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of RELEASE_TIME_TOLERANCE and RELEASE_TIME_FREQUENCY failed to mention that these are real numbers, and did not describe epsilon as machine precision. Moreover the default RELEASE_TIME_TOLERANCE was incorrectly stated to be epsilon times 10^9, where in fact it is epsilon times 10^11.
Thanks to @rbwinst-usgs for catching these mistakes.
Checklist of items for pull request