-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSD-316 new function to convert networkx to GraphData object #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for proposing this function; very useful! I left a few suggestions that would be nice to implement before adding this feature into the package. I'll be happy to discuss this further. 😃
@kibidi , you might need to sync your fork before working on the review. We've added a couple of new features into the |
Fix command
Fix command Add any branch to trigger action
83734e6
to
a2144b4
Compare
Co-authored-by: Diego Baptista Theuerkauf <34717973+diegoabt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @kibidi for your contribution. :)
My comments are only minor ones and related to style and standards. Great job! 👍
@jcpassy, thank you very much! It was fun! |
Added a function that converts a networkx data object to the required GraphData object. Also added a test and one of the dependent functions broke