Skip to content

Added tests for HuygensPSF #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Added tests for HuygensPSF #135

merged 2 commits into from
Mar 17, 2025

Conversation

LucVV
Copy link
Contributor

@LucVV LucVV commented Mar 14, 2025

Proposed change

I added tests for the HuygensPSF analysis.

Type of change

  • Example (a notebook demonstrating how to use ZOSPy for a specific application)
  • Bugfix (non-breaking change which fixes an issue)
  • New analysis (a wrapper around an OpticStudio analysis)
  • New feature (other than an analysis)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation (improvement of either the docstrings or the documentation website)

Additional information

  • Python version: 3.11
  • OpticStudio version: 20.3.2

Related issues

#133

Checklist

  • I have followed the contribution guidelines
  • The code has been linted, formatted and tested locally using hatch.
  • Local tests pass. Please fix any problems before opening a PR. If this is not possible, specify what doesn't work and why you can't fix it. --> the reference data is still to be generated
  • I added new tests for any features contributed, or updated existing tests.
  • I updated CHANGELOG.md with my changes (except for refactorings and changes in the documentation).

If you contributed an example:

  • I contributed my example as a Jupyter notebook.

@LucVV LucVV added the skip changelog It is not necessary to update the changelog for this PR label Mar 14, 2025
@LucVV LucVV added this to the v2.0.0 milestone Mar 14, 2025
@LucVV LucVV requested a review from crnh March 14, 2025 15:41
@LucVV LucVV mentioned this pull request Mar 14, 2025
13 tasks
@crnh
Copy link
Collaborator

crnh commented Mar 17, 2025

Thanks for noticing and fixing this! I added test reference data. All tests pass on my system.

@crnh crnh merged commit 9e239fa into v2.0.0 Mar 17, 2025
13 checks passed
@crnh crnh deleted the lvv/v2.0.0/test_psf branch March 17, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog It is not necessary to update the changelog for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants