Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group4 initial second world changes #12

Merged
merged 14 commits into from
Oct 19, 2023

Conversation

hexactinal
Copy link
Contributor

No description provided.

@hexactinal
Copy link
Contributor Author

Can't seem to add a label on the right side, so we might not have label permissions.

@FergusonAJ
Copy link
Contributor

Can't seem to add a label on the right side, so we might not have label permissions.

Good catch!
I gave all teams "Triage" access. Let me know if that's enough or not.

@amantham20 amantham20 self-requested a review October 7, 2023 22:25
amantham20

This comment was marked as outdated.

Copy link
Member

@amantham20 amantham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to also sync changes from the main repo. :)

Copy link
Member

@amantham20 amantham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add in
image
to ensure that main cmake picks the group4 main up

@amantham20
Copy link
Member

1 more change

the property for setting the character name has been changed to
world.AddAgent<cse491::TrashInterface>("Interface").SetProperty("symbol", '@');

@amantham20
Copy link
Member

image

I was able to get close to goal state but not on it not sure if this was the expected behavior

Copy link
Member

@amantham20 amantham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

CMakeLists.txt Outdated
@@ -12,7 +12,7 @@ set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")

# all the possible executables [each team can have their own configuration]
# copy over simple or same and change the accordingly
set(EXECUTABLES simple sfml_example)
set(EXECUTABLES simple sfml_example group4_main)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "group4_main" executable should be just "group4".

/**
* Creates a world with agents and a win flag
*/
class SecondWorld : public cse491::MazeWorld {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider deriving directly from WorldBase.

*/
SecondWorld() {
// Call parent class' constructor
cse491::MazeWorld();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling base class constructor can be done in initializer list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This current version will call the base class constructor twice)

@FergusonAJ FergusonAJ changed the base branch from main to development October 19, 2023 17:53
@FergusonAJ FergusonAJ merged commit d71f93f into MSU-CSE491:development Oct 19, 2023
1 check passed
amantham20 pushed a commit that referenced this pull request Nov 27, 2023
FergusonAJ pushed a commit that referenced this pull request Dec 6, 2023
Added Agent States into AgentBase.hpp + helper functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants