-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group4 initial second world changes #12
Conversation
Can't seem to add a label on the right side, so we might not have label permissions. |
Good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to also sync changes from the main repo. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more change the property for setting the character name has been changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!
CMakeLists.txt
Outdated
@@ -12,7 +12,7 @@ set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g") | |||
|
|||
# all the possible executables [each team can have their own configuration] | |||
# copy over simple or same and change the accordingly | |||
set(EXECUTABLES simple sfml_example) | |||
set(EXECUTABLES simple sfml_example group4_main) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "group4_main" executable should be just "group4".
source/Worlds/SecondWorld.hpp
Outdated
/** | ||
* Creates a world with agents and a win flag | ||
*/ | ||
class SecondWorld : public cse491::MazeWorld { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider deriving directly from WorldBase.
source/Worlds/SecondWorld.hpp
Outdated
*/ | ||
SecondWorld() { | ||
// Call parent class' constructor | ||
cse491::MazeWorld(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling base class constructor can be done in initializer list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This current version will call the base class constructor twice)
Added Agent States into AgentBase.hpp + helper functions
No description provided.