Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and clean CMake files #41

Merged
merged 15 commits into from
Oct 19, 2023

Conversation

FergusonAJ
Copy link
Contributor

@FergusonAJ FergusonAJ commented Oct 10, 2023

This PR contains a collection of incremental improvements to our CMake infrastructure:

  • Automatically find .cpp files to compile
    • For main application executables, these will be any .cpp files in /source/
    • For unit tests, these will be any .cpp files in that particular unit test folder (e.g., /tests/unit/core/*.cpp )
  • Add a TEST build type that will build only the tests
    • Extensible if we want ever want to turn off tests for certain build types
  • Streamlining of CMake files in the test directories
  • Add support for CTest
  • Add CMake files for other unit test directories (Worlds, Agents, and Interfaces)
  • Clean and comment main CMake files
  • Updates made to HowToCompile and HowToTest documentation
  • Source files handled via .cmake files with the same name as the .cpp

Closes #38

@amantham20 amantham20 self-requested a review October 11, 2023 01:15
Copy link
Member

@amantham20 amantham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might have to explain to me how the linking with all the hpp files work and how to create a new cofig/executable but except for that and the mentioned changes everything works good!

tests/unit/core/CMakeLists.txt Outdated Show resolved Hide resolved
tests/unit/Worlds/CMakeLists.txt Outdated Show resolved Hide resolved
@FergusonAJ FergusonAJ changed the base branch from main to development October 19, 2023 16:24
@FergusonAJ FergusonAJ merged commit 0d430ee into MSU-CSE491:development Oct 19, 2023
1 check passed
@FergusonAJ FergusonAJ mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants