Slight changes item_set to item_map in SelectAction function #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate VectoreMaze done and also added an asset.
…an area of mRenderRange around the player agent.
…nfrastructure built. menu now hold unique_ptr to buttons. maininterface has a font member used by reference by menu,button,textbox,messageboard
…ricted view range fixes, color changes
… works without layer. Also added menu button that a player can choose normal or enlarge mode.
|
We have created enlarge view functionality for the larger worlds. It works as expected. |
FergusonAJ
requested changes
Nov 15, 2023
source/Interfaces/MainInterface.cpp
Outdated
| mWindow.display(); | ||
| } | ||
| /** | ||
| * @brief Creates a 9x23 window of the symbol grid centered around the player's position. |
There was a problem hiding this comment.
I'm missing where 9 and 23 are coming from. Are they related to COL and ROW? If so, we might want to make those names a little more clear (e.g., NUM_ROWS or something)
There was a problem hiding this comment.
Ah, found them in the header. I do think the name could be a little more clear.
…the inventory class which draws the inventory onto the screen.
|
We have incorporated your suggestions |
FergusonAJ
approved these changes
Nov 17, 2023
…handling added to the textbox. resizing done too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.