Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

feat(simplification): fusion des scl en adc #1443

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Conversation

anis
Copy link
Contributor

@anis anis commented Sep 1, 2024

Related to #1416

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 32.89474% with 51 lines in your changes missing coverage. Please review.

Project coverage is 64.41%. Comparing base (9876549) to head (dd5fa18).

Files with missing lines Patch % Lines
...ations/20240828134125_etapes-scl-deviennent-adc.ts 0.00% 50 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (9876549) and HEAD (dd5fa18). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (9876549) HEAD (dd5fa18)
api 2 1
api-integration 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1443       +/-   ##
===========================================
- Coverage   80.90%   64.41%   -16.49%     
===========================================
  Files         728      729        +1     
  Lines       69708    69708               
  Branches     6570     4958     -1612     
===========================================
- Hits        56398    44904    -11494     
- Misses      13217    24611    +11394     
- Partials       93      193      +100     
Flag Coverage Δ
api 33.91% <31.08%> (-44.46%) ⬇️
api-integration ?
api-unit 33.91% <31.08%> (-0.11%) ⬇️
common 96.56% <100.00%> (+<0.01%) ⬆️
ui 73.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anis anis changed the title feat(simplification): fusion des types scl, wrd, apu feat(simplification): fusion des scl en adc Sep 1, 2024
@anis
Copy link
Contributor Author

anis commented Sep 1, 2024

Statut à ce jour : OK mais reste un titre à modifier pour rajouter un document vide à l'étape "saisine des collectivités locales" (https://camino.beta.gouv.fr/titres/m-ax-amadis-5-2022?demarcheSlug=m-ax-amadis-5-2022-oct01). En l'état du dév, si une étape "adc" existe dans la démarche, on migre les documents de la "scl" vers l"adc" existante puis on supprime la "scl", hors là il s'agit d'un cas particulier où une "adc" existe mais la "scl" n'a pas de documents, ce qui revient à simplement supprimer la "scl" (et donc perdre les infos de la date à laquelle elle a été faite.

@anis anis requested a review from bbbenja September 1, 2024 20:39
@anis anis force-pushed the fusion-scl-wrd-apu branch from c9ab3fc to 6a01126 Compare September 12, 2024 09:41
@anis anis marked this pull request as ready for review September 12, 2024 09:41
@anis anis force-pushed the fusion-scl-wrd-apu branch from 98fa615 to b4bbb39 Compare September 12, 2024 12:55
@MichaelBitard MichaelBitard merged commit c177c80 into master Sep 12, 2024
21 checks passed
@MichaelBitard MichaelBitard deleted the fusion-scl-wrd-apu branch September 12, 2024 15:20
@pohayscamino
Copy link
Collaborator

Il manque la Lettre de saisine des collectivités qui est obligatoire

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants