✨ Nom et localité du projet lauréat #2665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjlevesque
force-pushed
the
feat/nom-localite-laureat
branch
3 times, most recently
from
759951b to
1911637
Compare
VioMrqs
reviewed
Feb 10, 2025
VioMrqs
reviewed
Feb 10, 2025
packages/applications/projectors/src/subscribers/lauréat/lauréat.projector.ts
Show resolved
Hide resolved
VioMrqs
reviewed
Feb 10, 2025
There was a problem hiding this comment.
Quelques mini commentaires, mais la PR étant en draft ça me va, c'est propre sinon.
J'ai une interrogation sur le usecase ModifierLauréat en rapport avec mon sujet, pour savoir si on va le complexifier pour intégrer les autres champs modifiables (Actionnaire, Représentant Légal...) - à discuter !
packages/specifications/src/projet/lauréat/modifierLauréat.feature
Outdated
Show resolved
Hide resolved
packages/specifications/src/projet/lauréat/stepDefinitions/lauréat.then.ts
Show resolved
Hide resolved
benjlevesque
force-pushed
the
feat/nom-localite-laureat
branch
4 times, most recently
from
770cce6 to
3af64ff
Compare
VioMrqs
requested changes
Feb 14, 2025
packages/applications/legacy/src/controllers/project/postCorrectProjectData.ts
Show resolved
Hide resolved
packages/applications/legacy/src/views/pages/projectDetailsPage/sections/EditProjectData.tsx
Show resolved
Hide resolved
...s/applications/ssr/src/components/pages/lauréat/modifier/ModifierNomLocalitéLauréat.form.tsx
Show resolved
Hide resolved
...s/applications/ssr/src/components/pages/lauréat/modifier/ModifierNomLocalitéLauréat.page.tsx
Show resolved
Hide resolved
.../applications/ssr/src/components/pages/lauréat/modifier/modifierNomLocalitéLauréat.action.ts
Show resolved
Hide resolved
packages/domain/lauréat/src/garantiesFinancières/typeGarantiesFinancières.saga.ts
Show resolved
Hide resolved
VioMrqs
previously approved these changes
Feb 14, 2025
HubM
reviewed
Feb 17, 2025
packages/applications/projectors/src/subscribers/lauréat/lauréatNotifié.projector.ts
Outdated
Show resolved
Hide resolved
HubM
reviewed
Feb 17, 2025
HubM
reviewed
Feb 17, 2025
packages/specifications/src/projet/lauréat/modifierLauréat.feature
Outdated
Show resolved
Hide resolved
benjlevesque
force-pushed
the
feat/nom-localite-laureat
branch
from
316d501 to
89b7ec8
Compare
HubM
previously approved these changes
Feb 18, 2025
benjlevesque
force-pushed
the
feat/nom-localite-laureat
branch
from
3544ee0 to
d67c28e
Compare
HubM
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dans cette PR:
TODO :