-
Notifications
You must be signed in to change notification settings - Fork 27
switch to supported macOS 13 Intel runner #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nschimme
wants to merge
2
commits into
master
Choose a base branch
from
mac-intel-runner
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS 15 Intel runner image will be retired in Fall 2027. We should switch to macos-15-intel when macOS 14 is unsupported.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the GitHub Actions build-release workflow by replacing the soon-to-be-retired macOS 13 runner with the supported macos-14-large label in the OS matrix. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The PR title and description mention switching to
macos-15-intel
, but the diff replacesmacos-13
withmacos-14-large
—please align the description to reflect the actual runner change. - Consider adding a brief note on why
macos-14-large
was chosen over the standardmacos-14
image so other maintainers understand the rationale. - If Intel-specific testing is required, confirm that
macos-14-large
meets those requirements or explicitly target an Intel-labeled runner such asmacos-14-intel
if available.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and description mention switching to `macos-15-intel`, but the diff replaces `macos-13` with `macos-14-large`—please align the description to reflect the actual runner change.
- Consider adding a brief note on why `macos-14-large` was chosen over the standard `macos-14` image so other maintainers understand the rationale.
- If Intel-specific testing is required, confirm that `macos-14-large` meets those requirements or explicitly target an Intel-labeled runner such as `macos-14-intel` if available.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS 15 Intel runner image will be retired in Fall 2027. We should switch to macos-15-intel when macOS 14 is unsupported.
Summary by Sourcery
Enhancements: