Remove trailing whitespace from comments and update test output#11
Open
davispuh wants to merge 2 commits intoMVV90:mainfrom
Open
Remove trailing whitespace from comments and update test output#11davispuh wants to merge 2 commits intoMVV90:mainfrom
davispuh wants to merge 2 commits intoMVV90:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes trailing whitespace from generated comments in the FFI generator output. Previously, comments like # @return [Integer] (with a trailing space) are now generated as # @return [Integer] (without the trailing space). The changes also update test output files to reflect the corrected formatting after applying related PRs #9 and #10.
Changes:
- Modified the
write_arraymethod in the Writer class to conditionally add spacing between prefixes and entries - Updated all test output files to remove trailing whitespace from comments and blank comment lines
Reviewed changes
Copilot reviewed 88 out of 95 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/ffi_generator/generators/from_c_generator/writer.rb | Updated write_array method to intelligently handle spacing between prefixes and content |
| test/output/llvm-c/Transforms/Scalar.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/Transforms/PassManagerBuilder.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/Transforms/IPO.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/Target.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/Object.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/LinkTimeOptimizer.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/Initialization.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/Disassembler.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/BitWriter.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/BitReader.rb | Removed trailing whitespace from comments throughout the file |
| test/output/llvm-c/Analysis.rb | Removed trailing whitespace from comments throughout the file |
| test/output/include/internal/cef_*.rb | Removed trailing whitespace from comments across multiple CEF internal header files |
| test/output/include/capi/cef_*.rb | Removed trailing whitespace from comments across multiple CEF CAPI files |
| test/output/cairo-*.rb | Removed trailing whitespace from comments across multiple Cairo binding files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes trailing whitespace for created comments.
Previously it was
# @return [Integer](withat the end). This removes that.After applying #9 #10 I've updated test outputs aswell. Not sure how good idea is to commit those but that's how it's been done before.