Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change branch in widgets extension #161

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

eloiferrer
Copy link
Member

@eloiferrer eloiferrer commented Sep 30, 2024

MaRDI Pull Request

Changes:

  • The widgets extension is causing trouble in the XML backup. I suggest using a stable branch for this extension if possible.
XML backup
Warning: Undefined array key "NFDI_AAI_SECRET" in /shared/LocalSettings.d/OpenID_Connect.php on line 16
Error: The Widgets extension cannot be loaded. Check that all of its files are installed properly.

#0 /var/www/html/includes/GlobalFunctions.php(52): ExtensionRegistry->queue('/var/www/html/e...')
#1 /shared/LocalSettings.d/widgets.php(3): wfLoadExtension('Widgets')
#2 /shared/LocalSettings.php(72): include('/shared/LocalSe...')
#3 /var/www/html/includes/Setup.php(213): require_once('/shared/LocalSe...')
#4 /var/www/html/maintenance/doMaintenance.php(83): require_once('/var/www/html/i...')
#5 /var/www/html/maintenance/dumpBackup.php(144): require_once('/var/www/html/m...')
#6 {main}
Fatal error: Error Loading extension. Unable to open file /var/www/html/extensions/Widgets/extension.json: filemtime(): stat failed for /var/www/html/extensions/Widgets/extension.json in /var/www/html/includes/registration/MissingExtensionException.php on line 100
 ERROR: XML dump failed with status 255

Instructions for PR review:

  • Conceptual Review (Logic etc...)
  • Code Review (Review your implementation)
  • Checkout (Test changes locally)

Checklist for this PR:

@physikerwelt
Copy link
Member

Why do we need this extension? I would rather prefer to get rid of this non wmf deployed extension.

@eloiferrer
Copy link
Member Author

I don't really know, you added it three months ago: 7bf0ee3
I am also happy to remove it.

@physikerwelt
Copy link
Member

Ah no, this is different from widgets on Wikipedia. This is about including jupyter notebooks. So going to the release branch does seem to be ok. See https://staging.mardi4nfdi.org/wiki/TestWidget for a test.

@physikerwelt
Copy link
Member

@eloiferrer if you have this tested locally, could you test if the widget from above works with the rel branch?

@Daniel-Mietchen
Copy link

As per its Special:Version page, Wikidata uses the Gadgets Extension, and the Merge gadget is amongst those supported this way.

See also https://www.wikidata.org/wiki/Help:Merge#Gadget .

@eloiferrer
Copy link
Member Author

I tested it now with the REL branch and it also works. I am merging this.

@eloiferrer eloiferrer merged commit d07a6a5 into main Sep 30, 2024
4 checks passed
@eloiferrer eloiferrer deleted the change_widgets_branch branch September 30, 2024 14:34
@physikerwelt
Copy link
Member

As per its Special:Version page, Wikidata uses the Gadgets Extension, and the Merge gadget is amongst those supported this way.

See also https://www.wikidata.org/wiki/Help:Merge#Gadget .

We have already checked out the Gadgets extension
0096921

but not enabled yet

https://portal.mardi4nfdi.de/wiki/Special:Version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants