Load tests from "tests" subdirectory of package directory #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it much easier to install tests, since previously we were looking in the doc directory, and there's no good way to install m2 files there.
Previously we were missing the ending point, so "code" only gave us the first line.
Now go to Macaulay2/Core/tests instead of doc/Macaulay2/Core/tests Also remove a redundant installation of the Core tests from the cmake build. We were installing them twice! Also simplify the autotools installation rule a bit. Just use mkdir -p instead of individually installing all the directories.
Also sort the remaining keys in startup.m2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows package authors to add files to the
testssubdirectory of a package directory and have their contents automatically be loaded as package tests (like the Core tests), replacing the need to useTEST get(...). The JSON package is updated to use this feature as a proof of concept.Surprisingly, only one package (Polyhedra) already had a
testssubdirectory, so we shuffle around its files a bit.Cc: @mikestillman -- we talked about this idea briefly at Fields