Skip to content

Comments

Use JsonPropertyName in JsonStringEnumMemberConverter.#17

Merged
CodeBlanch merged 2 commits intoMacross-Software:developfrom
NN---:jsonpropertyname
Mar 14, 2021
Merged

Use JsonPropertyName in JsonStringEnumMemberConverter.#17
CodeBlanch merged 2 commits intoMacross-Software:developfrom
NN---:jsonpropertyname

Conversation

@NN---
Copy link
Contributor

@NN--- NN--- commented Mar 11, 2021

Fixes #16.

@CodeBlanch
Copy link
Member

Thanks @NN---! I'm going to merge and tweak it a bit. I'll reply back when a beta is up on nuget.

@NN---
Copy link
Contributor Author

NN--- commented Mar 14, 2021

Sure. Btw I implemented only serialize to json and didn’t implement deserializing.

@CodeBlanch CodeBlanch merged commit 27fa1c8 into Macross-Software:develop Mar 14, 2021
@CodeBlanch
Copy link
Member

2.1.0-beta1 should be up on nuget shortly. When you have time please take that for a spin and let me know if everything looks good for your use cases! Thanks again.

@NN--- NN--- deleted the jsonpropertyname branch March 14, 2021 22:30
@NN---
Copy link
Contributor Author

NN--- commented Apr 5, 2021

dotnet/runtime#31619

@0xced
Copy link
Contributor

0xced commented Apr 23, 2021

I just used this new feature for emmettnicholas/StacMan#12 and everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JsonStringEnumMemberConverter should use JsonPropertyName if present

3 participants