Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated OAuth spelling and README file #153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DevMahmoudMustafa
Copy link
Contributor

قمI updated the spelling of the word OAuth because there was a difference in the word written in the config file and the entity file, and I updated the connection method from JWT to OAuth in the README file.

@dienht
Copy link

dienht commented Oct 1, 2023

There is one error in line 59, Entry.php.

        if (strtolower(config('zoom.authentication_method')) === 'OAuth') {

It must change to:

        if (strtolower(config('zoom.authentication_method')) === 'oauth') {

Full method:

    public function newRequest()
    {
        if (strtolower(config('zoom.authentication_method')) === 'oauth') {
            return $this->oauthRequest();
        }

        throw new \ErrorException( "authentication_method " . config('zoom.authentication_method') . ' not found');
    }

I test, and it work. Thanks

@MAHMOUD202020
Copy link

Thank you, I will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants