Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding provision to add profile photo with responsive layout #6

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

khushChopra
Copy link
Contributor

The template did not provide a way to add a profile photo for better connection to visitors.

This is definitely subjective, would love to discuss it if needed. Will leave the final judgement to the owner of the repo.

@vercel
Copy link

vercel bot commented Jul 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
astro-portfolio-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 5:28am

@khushChopra
Copy link
Contributor Author

For reference - https://choprakhush.com/

@MaeWolff
Copy link
Owner

@khushChopra Good idea for those who want to add an image.
We could add the image link to the presentation.ts file and make it optional. What do you think?

@khushChopra
Copy link
Contributor Author

That would be the way to go. I will make that change.

@MaeWolff MaeWolff merged commit 9d87925 into MaeWolff:main Jul 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants