Use blocks instead of directly modifying the template#38
Open
kolaente wants to merge 7 commits intoMagenerds:masterfrom
Open
Use blocks instead of directly modifying the template#38kolaente wants to merge 7 commits intoMagenerds:masterfrom
kolaente wants to merge 7 commits intoMagenerds:masterfrom
Conversation
amenk
approved these changes
Mar 6, 2019
|
Looks good to me. Wondering why the initial implementation did not do it like this. |
Author
|
@amenk Same here. It even isn't that difficult as they already created the templates and even the blocks, they just didn't add them as blocks but as html directly... |
# Conflicts: # Model/Plugin/AfterPrice.php # etc/di.xml
|
Does this have chances to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a block via for the
afterPriceblock which can be modified using own custom xml.Why: we have a very customized Layout in one of our shops. Without this modification, it was not possible to move the price layout where we wanted it.