feature: added view that shows all books info in json#3
Open
feature: added view that shows all books info in json#3
Conversation
Melevir
approved these changes
Sep 26, 2023
books/serializer.py
Outdated
| from books.models import Book | ||
|
|
||
|
|
||
| def serialize_book(book: Book) -> dict: |
There was a problem hiding this comment.
Тут бы тайпеддикт в аннотации в идеале сделать
books/views.py
Outdated
| def get_all_books_json_view(request): | ||
| books = Book.objects.all() | ||
| if not books: | ||
| return JsonResponse(data={'data': {}, 'error': 'No books found'}, status=404) |
There was a problem hiding this comment.
Для списка сущностей пустой список – штатная ситуция, не надо делать 404
Melevir
reviewed
Sep 28, 2023
books/serializer.py
Outdated
| year_of_publishing: int | ||
| copies_printed: int | ||
| short_description: str | ||
|
|
books/serializer.py
Outdated
| from books.models import Book | ||
|
|
||
|
|
||
| class SerializedBook(TypedDict): |
There was a problem hiding this comment.
Я такие типы предпочитаю селить в отдельный файл, тогда реже циклические импорты возникают.
books/views.py
Outdated
| def get_all_books_json_view(request: HttpResponse) -> HttpResponse: | ||
| books = Book.objects.all() | ||
| if not books: | ||
| return JsonResponse(data={'data': {}, 'error': 'No books found'}) |
There was a problem hiding this comment.
Да говорю ж: если книг нету, это не ошибка, в дате будет пустой список, это значит шо книг нету, это норм. Избавься от этого ифа.
Melevir
reviewed
Oct 1, 2023
| from books.serializer import serialize_book | ||
|
|
||
|
|
||
| class Get_All_Books_Json_View(View): |
There was a problem hiding this comment.
Подчёркивания лишние, классы называем КемелКейсом
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.