add error handling to weather fetch functions, including cors

[sdetweil]

add error detection and handling for weather and cors fetch

fixes #3687

[sdetweil]

all tests run locally, electron and e2e

[khassel]

all tests run locally, electron and e2e

the 2 failed tests are unit tests - and they fail if I run them locally ...

[jbaboval]

Running this patch locally with success thus far.... Thanks!

[sdetweil]

Every other provider had to be fixed as well

[KristjanESPERANTO]

@sdetweil I worked on a solution and pushed it directly into your branch. I hope that's okay(?) Unfortunately, I was not able to provoke the error before and after this PR, but the tests are now running again. Can you check if the error occurs with it?

[sdetweil]

I saw. Will try to test today. I had forced the error path
Was trying not to change the providers

[KristjanESPERANTO]

@sdetweil What do you think? Can we merge this?

[sdetweil]

let me do some testing, been pretty busy lately

[KristjanESPERANTO]

No problem. Take your time 🙂

[KristjanESPERANTO]

I have rebased this PR because I still consider it a beneficial change 🙂 However, since I have added changes myself, I do not like to merge it myself. Could someone else please take another look at it?