Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an amount field to specify pCKB sent along with a tx #908

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

Keith-CY
Copy link
Member

This PR adds an pCKB field to specify the pCKB sent along with a transaction when the method of a contract is marked as payable

image

Ref: Magickbase/godwoken_explorer#1324

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
godwoken-explorer-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 2:15PM (UTC)

@codecov-commenter
Copy link

Codecov Report

Merging #908 (fb2823d) into develop (2b39afa) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #908      +/-   ##
===========================================
+ Coverage    67.47%   67.72%   +0.24%     
===========================================
  Files           18       18              
  Lines         1230     1230              
  Branches       743      743              
===========================================
+ Hits           830      833       +3     
+ Misses         346      344       -2     
+ Partials        54       53       -1     
Impacted Files Coverage Δ
pages/account/[id].tsx 60.97% <0.00%> (-1.22%) ⬇️
pages/index.tsx 90.59% <0.00%> (+4.27%) ⬆️

@FrederLu FrederLu merged commit 895d0de into develop Feb 21, 2023
@Keith-CY Keith-CY deleted the add-amount-field-on-writing-contract branch March 10, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants