Fixed bug in NLTE radiative transfer #247
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lower density regimes, population inversionsmight occur. If this happens, the opacity will become negative, leading to negative source functions and optical depths. The Feautrier solver cannot handle this. This is why we bound the opacities from below.
The actual change is just bounding the line opacities at the correct place in the code (+adding an extra parameter for bounding the line opacity and adding warnings when the line opacity becomes negative).