Skip to content

Fixed bug in NLTE radiative transfer #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

ThomasCeulemans
Copy link
Collaborator

In lower density regimes, population inversionsmight occur. If this happens, the opacity will become negative, leading to negative source functions and optical depths. The Feautrier solver cannot handle this. This is why we bound the opacities from below.

The actual change is just bounding the line opacities at the correct place in the code (+adding an extra parameter for bounding the line opacity and adding warnings when the line opacity becomes negative).

Correctly bounded negative opacities in case of populations inversion
@ThomasCeulemans ThomasCeulemans linked an issue Dec 1, 2023 that may be closed by this pull request
@ThomasCeulemans
Copy link
Collaborator Author

ThomasCeulemans commented Dec 4, 2023

This current build passes the test, but I am not confident that the NLTE radiative transfer does not show numerical errors (as the resulting images change depending on the hyperparameter values).

@ThomasCeulemans
Copy link
Collaborator Author

This solution does not seem to work, closing. I will replace it by manually resetting masering level populations to LTE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NLTE: negative opacities
2 participants