Initial commit for better imaging ray tracing. #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only stops when encountering boundary points on the opposite side of the domain. Will now also not compute anything if only boundary points are encountered.
|
I'll probably need to change at least one benchmark, related to imaging the phantom model. |
ThomasCeulemans
force-pushed
the
imager_correction
branch
from
04e6878 to
d5c2e2b
Compare
|
Accidentally commited code meant for testing the differences between the C++ and torch version. Thus force-pushed to get the remote branch working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only stops when encountering boundary points on the opposite side of the domain. Will now also not compute anything if only boundary points are encountered.
TODO: decide when/if to remove obsolete, commented code