Fixed discrete profiles not showing up in searches for resource profiles#184
Open
EmmasBox wants to merge 7 commits intoMainframe-Renewal-Project:devfrom
Open
Fixed discrete profiles not showing up in searches for resource profiles#184EmmasBox wants to merge 7 commits intoMainframe-Renewal-Project:devfrom
EmmasBox wants to merge 7 commits intoMainframe-Renewal-Project:devfrom
Conversation
github-actions
bot
added
the
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes bug reported here #182, it seems to have been introduced when the dataset search bug was fixed, because reverting to versions without that bug fix made it go away. I've tried to avoid re-introducing the dataset search bug, and seem to have succeeded from my tests.
I've also introduced a few search related tests to reduce the risk of future updates messing up the search, though I haven't added any search tests for dataset profiles yet.