Merged
Conversation
github-actions
bot
added
the
build
Author
|
I also update |
yinjie-z
force-pushed
the
fix-pre_commit
branch
from
5cac184 to
d009c5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the local build and pre-commit failures identified in #188.
By updating the C++ standard and refining the source file paths, this ensures that the project can be built and tested locally on Linux environments.
Changes
COMMON_INC.CXXSTANDARDfromc++14toc++17to supportstd::string_view.SRCZOSLIBpathing to preventclang++errors when.cfiles are missing in the test directory.Testing Performed
make teston Linux (Clang++).conversion.hppnow compiles correctly withstd::string_view.pre-commithooks now pass theunit-testandcppcheckstages.fix #188