fix(gha): add missing exe extension for windows

Signed-off-by: kaanyagci <kaan.yagci@makepad.fr>
Makepad-fr · Aug 12, 2024 · dca9feb · dca9feb
1 parent ef1d43c
commit dca9feb
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -49,8 +49,12 @@ jobs:
 
       - name: Build binary
         run: |
-          mkdir -p dist
-          GOOS=${{ matrix.goos }} GOARCH=${{ matrix.goarch }} go build -o dist/kickstart-${{ matrix.goos }}-${{ matrix.goarch }} main.go
+            mkdir -p dist
+            BINARY_NAME="kickstart-${{ matrix.goos }}-${{ matrix.goarch }}"
+            if [[ "${{ matrix.goos }}" == "windows" ]]; then
+              BINARY_NAME="${BINARY_NAME}.exe"
+            fi
+            GOOS=${{ matrix.goos }} GOARCH=${{ matrix.goarch }} go build -o dist/${BINARY_NAME} main.go
 
       - name: Run tests
         run: make test
@@ -95,12 +99,12 @@ jobs:
       - name: Download Windows AMD64 Artifact
         uses: actions/download-artifact@v3
         with:
-          name: kickstart-windows-amd64
+          name: kickstart-windows-amd64.exe
 
       - name: Download Windows ARM64 Artifact
         uses: actions/download-artifact@v3
         with:
-          name: kickstart-windows-arm64
+          name: kickstart-windows-arm64.exe
 
       - name: Create GitHub Release
         id: create_release