Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subscription operation logging with custom log level #110

Merged

Conversation

cuzzlor
Copy link
Collaborator

@cuzzlor cuzzlor commented Oct 19, 2023

What ?

Over in the graphql-apollo-server lib we recently tweaked the graphql operation logging plugin to support a little more output plus make the log level configurable.

This PR:

  • makes the log level for logging subscription operations configurable (e.g. we might wish to log them as audit)
  • logs subscription operations using the logGraphQLOperation method via logSubscriptionOperation, aligning output somewhat to what the graphql-apollo-server#graphqlOperationLoggingPlugin produces

@cuzzlor cuzzlor requested a review from boblat October 19, 2023 09:46
@cuzzlor cuzzlor force-pushed the support-subscription-operation-logging-with-custom-log-level branch from 1fa9505 to 97da08d Compare October 20, 2023 02:05
@cuzzlor cuzzlor merged commit d969921 into main Oct 20, 2023
1 check passed
@cuzzlor cuzzlor deleted the support-subscription-operation-logging-with-custom-log-level branch October 20, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants