Skip to content

Commit

Permalink
Make artifact names unique (#3481)
Browse files Browse the repository at this point in the history
* Make artifact names unique

* remove unnecessary arch, os, version info from artifacts
  • Loading branch information
jkrumbiegel authored Dec 18, 2023
1 parent 9aef324 commit da7bcc8
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/reference_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,10 @@ jobs:
julia --color=yes --project=monorepo -e 'using Pkg; Pkg.test("CairoMakie", coverage=true)'
&& echo "TESTS_SUCCESSFUL=true" >> $GITHUB_ENV
- name: Upload test Artifacts
if: matrix.version == '1'
uses: actions/upload-artifact@v3
with:
name: ReferenceImages_${{ matrix.os }}_${{ matrix.arch }}_${{ matrix.version }}
name: ReferenceImages_CairoMakie
path: ./CairoMakie/test/recorded_reference_images/
- name: Fail after artifacts if tests failed
if: ${{ env.TESTS_SUCCESSFUL != 'true' }}
Expand Down Expand Up @@ -100,9 +101,10 @@ jobs:
DISPLAY=:0 xvfb-run -s '-screen 0 1024x768x24' julia --color=yes --project=monorepo -e 'using Pkg; Pkg.test("GLMakie", coverage=true)'
&& echo "TESTS_SUCCESSFUL=true" >> $GITHUB_ENV
- name: Upload test Artifacts
if: matrix.version == '1'
uses: actions/upload-artifact@v3
with:
name: ReferenceImages_${{ matrix.os }}_${{ matrix.arch }}_${{ matrix.version }}
name: ReferenceImages_GLMakie
path: |
./GLMakie/test/recorded_reference_images/
- name: Save number of missing refimages to file
Expand Down Expand Up @@ -160,9 +162,10 @@ jobs:
DISPLAY=:0 xvfb-run -s '-screen 0 1024x768x24' julia --color=yes --project=monorepo -e 'using Pkg; Pkg.test("WGLMakie", coverage=true)'
&& echo "TESTS_SUCCESSFUL=true" >> $GITHUB_ENV
- name: Upload test Artifacts
if: matrix.version == '1'
uses: actions/upload-artifact@v3
with:
name: ReferenceImages_${{ matrix.os }}_${{ matrix.arch }}_${{ matrix.version }}
name: ReferenceImages_WGLMakie
path: ./WGLMakie/test/recorded_reference_images/
- name: Fail after artifacts if tests failed
if: ${{ env.TESTS_SUCCESSFUL != 'true' }}
Expand Down

0 comments on commit da7bcc8

Please sign in to comment.