Make autolimits! default to current_axis() #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes `Makie.autolimits!` default to using `current_axis()`
KronosTheLate
changed the title
src/makielayout/blocks/axis.jl
Outdated
| """ | ||
| function autolimits!(ax::Axis) | ||
| ax.limits[] = (nothing, nothing) | ||
| return | ||
| end | ||
| autolimits!() = autolimits!(current_axis()) |
There was a problem hiding this comment.
I think this should check for current_axis returning nothing!
There was a problem hiding this comment.
That sounds like a very good idea. I implemented this check. Below is a demo:
julia> using GLMakie
julia> Makie.autolimits!
autolimits! (generic function with 4 methods)
julia> function autolimits!()
curr_ax = current_axis()
isnothing(curr_ax) && throw(ArgumentError("Attempted to call `autolimits!` on `current_axis()`, but `current_axis()` returned nothing."))
autolimits!()
end
autolimits! (generic function with 1 method)
julia> autolimits!()
ERROR: ArgumentError: Attempted to call `autolimits!` on `current_axis()`, but `current_axis()` returned nothing.
Stacktrace:
[1] autolimits!()
@ Main ./REPL[5]:3
[2] top-level scope
@ REPL[6]:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Makie.autolimits!default to usingcurrent_axis()Type of change
Delete options that do not apply:
Checklist