Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test each backend for relocatability #4288

Merged
merged 12 commits into from
Oct 24, 2024
Merged

Test each backend for relocatability #4288

merged 12 commits into from
Oct 24, 2024

Conversation

jkrumbiegel
Copy link
Member

No description provided.

@jkrumbiegel jkrumbiegel added the skip-changelog Skips changelog enforcer label Aug 30, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Aug 30, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 6.30s (6.18, 6.45) 0.07+- 162.65ms (156.98, 172.20) 3.98+- 0.51s (0.46, 1.24) 0.17+- 6.87ms (6.79, 6.96) 0.05+- 25.64ms (25.44, 25.87) 0.13+-
master 6.28s (6.18, 6.33) 0.04+- 161.64ms (158.56, 164.15) 1.62+- 471.74ms (466.07, 483.06) 4.18+- 6.81ms (6.67, 7.18) 0.11+- 25.71ms (25.41, 26.06) 0.19+-
evaluation 1.00x invariant, 0.02s (0.36d, 0.26p, 0.06std) 0.99x invariant, 1.01ms (0.33d, 0.30p, 2.80std) 0.92x noisy🤷‍♀️, 0.04s (0.32d, 0.32p, 0.09std) 0.99x slower X, 0.07ms (0.81d, 0.02p, 0.08std) 1.00x invariant, -0.07ms (-0.42d, 0.19p, 0.16std)
CairoMakie 5.96s (5.86, 6.10) 0.06+- 163.10ms (158.71, 170.55) 2.93+- 198.08ms (194.52, 204.44) 2.63+- 6.81ms (6.68, 7.15) 0.10+- 1.08ms (1.06, 1.10) 0.01+-
master 5.93s (5.87, 6.00) 0.03+- 162.28ms (158.57, 167.66) 2.93+- 198.44ms (195.21, 203.29) 2.43+- 6.78ms (6.65, 6.88) 0.07+- 1.08ms (1.07, 1.09) 0.01+-
evaluation 0.99x invariant, 0.03s (0.63d, 0.06p, 0.05std) 1.00x invariant, 0.81ms (0.28d, 0.38p, 2.93std) 1.00x invariant, -0.35ms (-0.14d, 0.66p, 2.53std) 1.00x invariant, 0.03ms (0.37d, 0.25p, 0.08std) 1.00x invariant, -0.0ms (-0.13d, 0.68p, 0.01std)
WGLMakie 6.84s (6.66, 7.10) 0.11+- 166.32ms (161.50, 180.28) 3.81+- 5.71s (5.61, 5.85) 0.06+- 10.42ms (10.18, 10.70) 0.15+- 148.93ms (144.89, 183.09) 8.10+-
master 6.80s (6.66, 6.97) 0.09+- 168.31ms (159.53, 196.73) 8.20+- 6.05s (5.90, 6.46) 0.14+- 10.59ms (10.24, 11.69) 0.31+- 147.80ms (144.70, 150.60) 1.31+-
evaluation 0.99x invariant, 0.04s (0.38d, 0.23p, 0.10std) 1.01x invariant, -1.99ms (-0.31d, 0.33p, 6.00std) 1.06x faster✅, -0.34s (-3.23d, 0.00p, 0.10std) 1.02x faster ✓, -0.17ms (-0.71d, 0.03p, 0.23std) 0.99x invariant, 1.13ms (0.20d, 0.54p, 4.71std)

@SimonDanisch
Copy link
Member

This needs: davidanthoff/Electron.jl#130

@SimonDanisch SimonDanisch merged commit 445d7ae into master Oct 24, 2024
15 of 17 checks passed
@SimonDanisch SimonDanisch deleted the jk/relocatability branch October 24, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants