-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullbox #4305
base: master
Are you sure you want to change the base?
Fullbox #4305
Conversation
Framelines is drawn. Added fields xspinecolor_4, yspinecolor_4 and zspinecolor_4 to control the color of the 4th line when the fullbox is drawn.
to_topscene_small_z_2d. Createted function to_topscene_big_z_2d to project points into parent space with a big z value
Added variable fraimpoints_fullbox replicating the functionality of assining to framepoints_main using p7 and p8 and the function to_topscene_big_z_2d. Added an if statement to add the front lines of the fullbox if the field fullbox od Axis3 is true.
visibility by ax.fullbox && attr(:spinesvisible).
The theme should set these new spines to invisible also. Maybe fullbox is not the best name either because it doesn't say anything about the other spines, what about |
Hm now that I think about it, do we really need the separate Boolean keyword? Maybe it's enough to just have these three new visible attributes, and they're just false in all default themes. |
I see the point. Would you suggest creating a theme (called full_box for example?!) to set all spines visible then? |
I don't think a theme is warranted for three values, if people like their plots this way they're going to call |
Description
Implemented option to close an Axis3's outline box. When the new field
fullbox = true
for an Axis3-object the 3 remaining spines of the box are created in front of what is inside the space.Example:
Fixes #2349
Add option to close an Axis3's outline box
Type of change
Delete options that do not apply: