Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make space work for BarPlot #4435

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: make space work for BarPlot #4435

merged 3 commits into from
Oct 10, 2024

Conversation

EdsterG
Copy link
Contributor

@EdsterG EdsterG commented Oct 1, 2024 •
edited
Loading

Description

Makes BarPlot work with the space attribute.

Side note, the current approach to forwarding parameters seems very error prone. Are there any thoughts/prototypes to automate parameter passing?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@EdsterG
Copy link
Contributor Author

EdsterG commented Oct 2, 2024

Found the prototype, this PR is made obsolete by #4399. If there's no plan to merge #4399 soon, let's get this patch in?

@EdsterG
Copy link
Contributor Author

EdsterG commented Oct 3, 2024

Thanks for the fix, I had a local commit with the same typo, guess I cherry picked the wrong one.

@ffreyer ffreyer mentioned this pull request Oct 10, 2024
Draft
4 tasks
@EdsterG
Copy link
Contributor Author

EdsterG commented Oct 10, 2024

@SimonDanisch shall we merge this, given how trivial the change is?

ffreyer
ffreyer approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@ffreyer ffreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with that

@SimonDanisch SimonDanisch merged commit 5850070 into MakieOrg:master Oct 10, 2024
17 of 18 checks passed
@EdsterG EdsterG deleted the fix_barplot_space branch October 10, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffreyer ffreyer ffreyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
PR review
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdsterG @ffreyer @SimonDanisch