Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make benchmark plots and post a gist with them #4515

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

jkrumbiegel
Copy link
Member

No description provided.

@jkrumbiegel jkrumbiegel added the skip-changelog Skips changelog enforcer label Oct 24, 2024
@jkrumbiegel
Copy link
Member Author

@SimonDanisch this works now, a link is in the Benchmark Results status under Details. For some reason it's still prone to false positives even in purely visual form, as there shouldn't be differences vs master on this branch here.

Also, it's not as visible as the comment system we had before, we could in principle bring the commenting back but link the images from the gist. I think that works, here's an example link, the format is https://gist.githubusercontent.com/MakieBot/e8365e6c46abbd310446c463f3cc893d/raw/CairoMakie.svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

1 participant