Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add precompile workload #37

Merged
merged 11 commits into from
Nov 24, 2023
Merged

add precompile workload #37

merged 11 commits into from
Nov 24, 2023

Conversation

palday
Copy link
Collaborator

@palday palday commented Nov 17, 2023

Additionally:

  • added Aqua to tests
  • added stdlib compat entries as now required in the General registry
  • fixed docs build

Copy link
Collaborator

@behinger behinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Phillip!

Edit: just saw that docs fail, probably because of Documenter 1.0 which throws many more errors

src/TopoPlots.jl Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f65520) 83.85% compared to head (e56775a) 85.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   83.85%   85.54%   +1.69%     
==========================================
  Files           5        5              
  Lines         161      166       +5     
==========================================
+ Hits          135      142       +7     
+ Misses         26       24       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@behinger
Copy link
Collaborator

giphy

@palday palday requested a review from behinger November 20, 2023 16:42
@palday palday merged commit cdfc8e9 into master Nov 24, 2023
3 checks passed
@palday palday deleted the pa/precompile branch November 24, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants