MPRIS DBus integration & multiple media players #98
Conversation
The media player panel now also lists all media players. Styling is still to be done.
It will only fetch MPRIS player data without refetching the list of MPRIS players if there was no DBus signal that the list of players changed.
Media Player module will now show the title if there's only 1 player, mimicking the previous behaviour. It will show the note icon if there is more than 1 player.
src/modules/media_player.rs
Outdated
| iced::widget::horizontal_rule(2).into(), | ||
| container( | ||
| column![] | ||
| .push_maybe(d.song.clone().map(text)) |
There was a problem hiding this comment.
Would be nice to have a fallback value where we cannot find the song title. Something like NoTitle or boh I don't know some common default value in this case 😅
There was a problem hiding this comment.
Went with "No Title" for now.
I think in the future it can rely on Track_Id as a fallback, though if it has custom formatting support its back to square one. I have not looked at other status bars/shells to see what they do, but would think that's probably the easiest way to figure out what's sensible.
Was trying to keep the changes to a minimum with at least feature parity with #94 and the multiple players support. Will look into it along with checking |
Simplified a filter + map into a filter_map
Simplified a future::ready with async move
MediaPlayer module no longer keeps its own state of the connected players. It instead relies on the data in the MPRIS service itself.
|
Have made the changes with the suggested fixes. |
src/modules/media_player.rs
Outdated
| s.deref() | ||
| .iter() | ||
| .flat_map(|d| { | ||
| let d = d.clone(); | ||
| let title = text(Self::get_title(&d, config)); |
There was a problem hiding this comment.
| s.deref() | |
| .iter() | |
| .flat_map(|d| { | |
| let d = d.clone(); | |
| let title = text(Self::get_title(&d, config)); | |
| s.iter() | |
| .flat_map(|d| { | |
| let title = text(Self::get_title(d, config)); |
src/modules/media_player.rs
Outdated
| self.service.as_ref().and_then(|s| { | ||
| let data = s.deref(); | ||
| match data.len() { | ||
| 0 => None, | ||
| _ => Some(( | ||
| row![ | ||
| icon(Icons::MusicNote), | ||
| text(Self::get_title(&data[0], config)) |
There was a problem hiding this comment.
| self.service.as_ref().and_then(|s| { | |
| let data = s.deref(); | |
| match data.len() { | |
| 0 => None, | |
| _ => Some(( | |
| row![ | |
| icon(Icons::MusicNote), | |
| text(Self::get_title(&data[0], config)) | |
| self.service.as_ref().and_then(|s| { | |
| match s.len() { | |
| 0 => None, | |
| _ => Some(( | |
| row![ | |
| icon(Icons::MusicNote), | |
| text(Self::get_title(&s[0], config)) |
It seems correct on my end and when looking at master though. Is my mind fried 😵💫??? # Media player module configuration
mediaPlayer:
maxTitleLength: 100 # optional, default 100Also pushed the changes. |
Ahah no that section it's ok. Last time I forgot to check this other section Also, the CI shows an unused |
|
Fixed the use declaration and updated the README. |
|
Great job! |
Directly integrate with MPRIS DBus interface instead of using
playerctl. With this, CPU time is significantly lower (simple check throughtop).This PR also implements support for displaying more than 1 player at a time in the Media Player module menu.