[WIP] [POC] Implement Condensed VA syntax #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
commented
Sep 26, 2025
| arel ||= virtual_delegate_arel(source, to_ref) | ||
| elsif block_given? | ||
| define_method(name) do | ||
| has_attribute?(name) ? self[name] : instance_eval(&block) |
There was a problem hiding this comment.
this is so nice.
Before
We can do minimal common manipulations for sql in the TableProxy, but can't do any common manipulation for the ruby code.
After
Adding stuff to ruby like the has_attribute? pattern is a big win.
Besides cutting down on the noise, we often forget to add this block and forgetting it can cause problems at runtime.
kbrock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: still have to convert across
WIP: need to verify this doesn't bloat memory too much due to class closure in the lambda
Fixes #203
===
Not thrilled that we are keeping the method closure from virtual_attribute. that has quite a bit of data in there and the lambda