-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to el9 #563
Upgrade to el9 #563
Conversation
@@ -111,7 +108,7 @@ echo "" >> /etc/ssh/sshd_config | |||
dnf -C -y --noplugins remove linux-firmware doxygen | |||
|
|||
# Ensure packages are up to date | |||
dnf -y update --nobest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need the --nobest
. I think it was added for an ansible rpm issue, but we're on a much newer version now and there shouldn't be any dependency issues anymore. (I didn't see any issues during install or update of my test appliance without it)
@@ -39,7 +39,7 @@ | |||
STORAGE_DIR = BUILD_BASE.join("storage") | |||
ISOS_DIR = Pathname.new("/build/isos") # NOTE: We are not using run-specific BUILD_BASE in order to share the source iso across builds | |||
IMAGES_DIR = BUILD_BASE.join("images") | |||
ISO_FILE = ISOS_DIR.glob("CentOS-Stream-8-x86_64-*-dvd1.iso").sort.last.expand_path | |||
ISO_FILE = ISOS_DIR.glob("CentOS-Stream-9-*-x86_64-dvd1.iso").sort.last.expand_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to quickly to change this to the much smaller boot ISO, but that didn't work. I'll open an issue to investigate that. It could shave 10-20 minutes per image off of the build time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kickstarts/centos8_build_machine.ks
Outdated
@@ -1,4 +1,4 @@ | |||
#version=RHEL8 | |||
#version=RHEL9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this file right now, but I'd like to keep it as a reference for setting up new build machines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth converting it to an RPM or ansible playbook or something.
kickstarts/centos8_build_machine.ks
Outdated
logvol swap --vgname=kegerator8 --name=swap --size=8192 | ||
logvol / --vgname=kegerator8 --name=root --size=20480 --fstype=xfs | ||
logvol /build --vgname=kegerator8 --name=build --size=20480 --fstype=xfs --grow | ||
volgroup kegerator pv.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is so silly haha - can we pick any volgroup name or does it have to be this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to remove changes to this file from this PR
kickstarts/centos8_build_machine.ks
Outdated
network --hostname=kegerator8.example.com # CHANGEME | ||
network --hostname=kegerator.example.com # CHANGEME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here?
Overall, LGTM - had a few questions. |
We may need updates to some packages that were sourced from there (python3-venv)
Checked commits bdunne/manageiq-appliance-build@8310266~...896a8a5 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint scripts/vmbuild.rb
|
No description provided.