Merge pull request #458 from Ixrec/zero-banners-error

#455 Proper error message when shuffling/rotating with zero banners
Manechat · Aug 6, 2023 · 1b36eb6 · 1b36eb6
2 parents 2436118 + 7b6e9b0
commit 1b36eb6
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/Izzy-Moonbot/Service/ScheduleService.cs b/Izzy-Moonbot/Service/ScheduleService.cs
@@ -358,14 +358,18 @@ public async Task Unicycle_BannerRotation(ScheduledBannerRotationJob job, IIzzyG
             _logger.Log("Unicycle_BannerRotation early returning because BannerMode is None.");
             return;
         }
-        if (_config.BannerMode == ConfigListener.BannerMode.Shuffle && _config.BannerImages.Count == 0)
-        {
-            _logger.Log("Unicycle_BannerRotation early returning because BannerMode is Shuffle but BannerImages is empty.");
-            return;
-        }
 
         if (_config.BannerMode == ConfigListener.BannerMode.Shuffle || _config.BannerMode == ConfigListener.BannerMode.Rotate)
         {
+            if (_config.BannerImages.Count == 0)
+            {
+                var modeString = _config.BannerMode.GetType().GetEnumName(_config.BannerMode);
+                var msg = $"Unable to change banner because BannerMode is {modeString} but BannerImages is empty";
+                await _modLogging.CreateModLog(guild).SetContent(msg).SetFileLogContent(msg).Send();
+                _logger.Log(msg);
+                return;
+            }
+
             try
             {
                 int bannerIndex;