Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#455 Proper error message when shuffling/rotating with zero banners #458

Merged
merged 1 commit into from
Aug 6, 2023
Merged

#455 Proper error message when shuffling/rotating with zero banners #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions Izzy-Moonbot/Service/ScheduleService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,14 +358,18 @@ public async Task Unicycle_BannerRotation(ScheduledBannerRotationJob job, IIzzyG
_logger.Log("Unicycle_BannerRotation early returning because BannerMode is None.");
return;
}
if (_config.BannerMode == ConfigListener.BannerMode.Shuffle && _config.BannerImages.Count == 0)
{
_logger.Log("Unicycle_BannerRotation early returning because BannerMode is Shuffle but BannerImages is empty.");
return;
}

if (_config.BannerMode == ConfigListener.BannerMode.Shuffle || _config.BannerMode == ConfigListener.BannerMode.Rotate)
{
if (_config.BannerImages.Count == 0)
{
var modeString = _config.BannerMode.GetType().GetEnumName(_config.BannerMode);
var msg = $"Unable to change banner because BannerMode is {modeString} but BannerImages is empty";
await _modLogging.CreateModLog(guild).SetContent(msg).SetFileLogContent(msg).Send();
_logger.Log(msg);
return;
}

try
{
int bannerIndex;
Expand Down
Loading