Merge pull request #214 from Mangopay/feature/add_fees_param

Add fees param to instant conversion
Mangopay · Mar 7, 2024 · ec2f176 · ec2f176
2 parents 988b7d6 + f9ee39e
commit ec2f176
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/MangoPay.SDK.Tests/ApiInstantConversionTest.cs b/MangoPay.SDK.Tests/ApiInstantConversionTest.cs
@@ -29,6 +29,7 @@ public async Task Test_CreateInstantConversion()
             Assert.IsNotNull(createdInstantConversion);
             Assert.IsNotNull(createdInstantConversion.CreditedFunds.Amount);
             Assert.IsNotNull(createdInstantConversion.DebitedFunds.Amount);
+            Assert.IsNotNull(createdInstantConversion.Fees);
             Assert.AreEqual(createdInstantConversion.Status, TransactionStatus.SUCCEEDED);
             Assert.AreEqual(createdInstantConversion.Type, TransactionType.CONVERSION);
         }
@@ -42,6 +43,7 @@ public async Task Test_GetInstantConversion()
             Assert.IsNotNull(returnedInstantConversion);
             Assert.IsNotNull(returnedInstantConversion.CreditedFunds.Amount);
             Assert.IsNotNull(returnedInstantConversion.DebitedFunds.Amount);
+            Assert.IsNotNull(returnedInstantConversion.Fees);
             Assert.AreEqual(returnedInstantConversion.Status, TransactionStatus.SUCCEEDED);
             Assert.AreEqual(returnedInstantConversion.Type, TransactionType.CONVERSION);
         }
@@ -61,6 +63,7 @@ private async Task<InstantConversionDTO> CreateInstantConversion()
                 creditedWallet.Id,
                 new Money { Amount = 30, Currency = CurrencyIso.EUR },
                 new Money { Currency = CurrencyIso.GBP },
+                new Money { Amount = 9, Currency = CurrencyIso.EUR},
                 "create instant conversion"
             );
 

diff --git a/MangoPay.SDK/Entities/GET/InstantConversionDTO.cs b/MangoPay.SDK/Entities/GET/InstantConversionDTO.cs
@@ -50,5 +50,10 @@ public class InstantConversionDTO: EntityBase
         /// The statuses CREATED and FAILED return an ExecutionDate of null</summary>
         [JsonConverter(typeof(Core.UnixDateTimeConverter))]
         public DateTime ExecutionDate { get; set; }
+
+
+        /// <summary>Information about the fees taken by the platform for
+        /// this transaction (and hence transferred to the Fees Wallet).</summary>
+        public Money Fees { get; set; }
     }
 }
diff --git a/MangoPay.SDK/Entities/POST/InstantConversionPostDTO.cs b/MangoPay.SDK/Entities/POST/InstantConversionPostDTO.cs
@@ -4,14 +4,15 @@ public class InstantConversionPostDTO: EntityPostBase
     {
 
         public InstantConversionPostDTO(string authorId, string debitedWalletId, string creditedWalletId,
-            Money debitedFunds, Money creditedFunds,
+            Money debitedFunds, Money creditedFunds, Money fees,
             string tag = null)
         {
             AuthorId = authorId;
             DebitedWalletId = debitedWalletId;
             CreditedWalletId = creditedWalletId;
             DebitedFunds = debitedFunds;
             CreditedFunds = creditedFunds;
+            Fees = fees;
             Tag = tag;
         }
 
@@ -29,5 +30,9 @@ public InstantConversionPostDTO(string authorId, string debitedWalletId, string
 
         /// <summary>The buy funds</summary>
         public Money CreditedFunds { get; set; }
+
+        /// <summary>Information about the fees taken by the platform for
+        /// this transaction (and hence transferred to the Fees Wallet).</summary>
+        public Money Fees { get; set; }
     }
 }