Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop ignoring manim.plugins errors in mypy.ini #4006

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Stop ignoring manim.plugins errors in mypy.ini #4006

merged 1 commit into from
Nov 10, 2024
+5 −9

Conversation

chopan050
Copy link
Contributor

Related issue: #3375

manim.plugins already has typings. It only needs to have its configuration modified in mypy.ini.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

@chopan050 chopan050 mentioned this pull request Nov 10, 2024
Open
22 tasks
@chopan050 chopan050 added pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! typehints For adding/discussing typehints labels Nov 10, 2024
@behackl behackl merged commit a21a5e5 into ManimCommunity:main Nov 10, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGrace2282 JasonGrace2282 JasonGrace2282 approved these changes

Assignees
No one assigned
Labels
pr:easy review There is nothing particular (i.e, it's about a general/small thing) to know for review! typehints For adding/discussing typehints
Projects
Dev Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chopan050 @JasonGrace2282 @behackl