-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Bump minimum Python to 3.11 and av to 14.0.1 #4385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "Natural Language :: English", | ||
| ] | ||
| requires-python = ">=3.9" | ||
| requires-python = ">=3.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we should probably also remember to do this for mypy and ruff
|
Regarding the TODOs:
As Python 3.14 was just released and Python 3.11 is now 3+ years old, if we want to be in accordance with SPEC 0, we'll also have to remove support for 3.11 and bump the minimum version to 3.12... |
In accordance with https://scientific-python.org/specs/spec-0000/ (which we have at some point loosely discussed to follow), our minimum supported Python version could be bumped to 3.11.
This also bumps the minimum required version of av to at least 14.0.1, while our metadata tests only appear to be fixed and working with 15.0.0, their latest release as of right now.
The PR is a draft for now as some additional cleanup is required; e.g.,
importlib-metadatacan be removed, the dependecies can remove the distinctions for Python 3.10.TODOs
importlib-metadatatyping_extensions?