Skip to content

Keyword argument to NumberLine constructor for double sided tips #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Keyword argument to NumberLine constructor for double sided tips #4488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44522bb
an implementation of double-sided tips w/minimal changes to existing …
josiest Nov 28, 2025
6398f59
fixed edge case for numberline where step is very small
josiest Nov 28, 2025
c3f01c8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions manim/mobject/graphing/number_line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ class NumberLine(Line):
The thickness of the line.
include_tip
Whether to add a tip to the end of the line.
include_double_sided_tip
Should tips be added on both ends? Ignores value of include_tip if passed True
tip_width
The width of the tip.
tip_height
Expand Down Expand Up @@ -156,6 +158,7 @@ def __init__(
stroke_width: float = 2.0,
# tip
include_tip: bool = False,
include_double_sided_tip: bool = False,
tip_width: float = DEFAULT_ARROW_TIP_LENGTH,
tip_height: float = DEFAULT_ARROW_TIP_LENGTH,
tip_shape: type[ArrowTip] | None = None,
Expand Down Expand Up @@ -210,6 +213,7 @@ def __init__(
self.rotation = rotation
# tip
self.include_tip = include_tip
self.include_double_sided_tip = include_double_sided_tip
self.tip_width = tip_width
self.tip_height = tip_height
# numbers
Expand Down Expand Up @@ -238,14 +242,23 @@ def __init__(

self.center()

if self.include_tip:
if self.include_double_sided_tip or self.include_tip:
self.add_tip(
tip_length=self.tip_height,
tip_width=self.tip_width,
tip_shape=tip_shape,
)
self.tip.set_stroke(self.stroke_color, self.stroke_width)

if self.include_double_sided_tip:
self.add_tip(
tip_length=self.tip_height,
tip_width=self.tip_width,
tip_shape=tip_shape,
at_start=True,
)
self.start_tip.set_stroke(self.stroke_color, self.stroke_width)

if self.include_ticks:
self.add_ticks()

Expand Down Expand Up @@ -335,11 +348,14 @@ def get_tick_range(self) -> np.ndarray:
Returns
-------
np.ndarray
A numpy array of floats represnting values along the number line.
A numpy array of floats representing values along the number line.
"""
x_min, x_max, x_step = self.x_range
if not self.include_tip:
x_max += 1e-6
if not self.include_tip and not self.include_double_sided_tip:
x_max += min(1e-6, x_step / 2)

if not self.include_double_sided_tip:
x_min -= min(1e-6, x_step / 2)

# Handle cases where min and max are both positive or both negative
if x_min < x_max < 0 or x_max > x_min > 0:
Expand All @@ -349,7 +365,7 @@ def get_tick_range(self) -> np.ndarray:
if self.exclude_origin_tick:
start_point += x_step

x_min_segment = np.arange(start_point, np.abs(x_min) + 1e-6, x_step) * -1
x_min_segment = np.arange(start_point, np.abs(x_min), x_step) * -1
x_max_segment = np.arange(start_point, x_max, x_step)

tick_range = np.unique(np.concatenate((x_min_segment, x_max_segment)))
Expand Down
Loading