Skip to content

fix-html-clearvalue-bug#51

Open
alibazregar wants to merge 3 commits intomasterfrom
fix-pop-up-bug-
Open

fix-html-clearvalue-bug#51
alibazregar wants to merge 3 commits intomasterfrom
fix-pop-up-bug-

Conversation

@alibazregar
Copy link
Contributor

No description provided.

Copy link
Contributor

@Qamsari Qamsari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please visit my issues.

import IDictionary from "../../IDictionary";
import ConnectionOptions from "./ConnectionOptions";
import StreamPromise from "./StreamPromise";
//@ts-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible please remove it.

private _pairBtnContainer: HTMLDivElement;
readonly owner: QuestionContainer;
readonly answer: IAnswerPart;
answer: IAnswerPart;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The answer must be read-only and only set once in edit mode!

Comment on lines +185 to +187
public clearAnswer(){
this.answer =null
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For adding support of clear, please use another method!

export default class HTMLFieldType extends QuestionPart {
private valueInput: HTMLInputElement;
private value: IUserActionPart;
public value: IUserActionPart | string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants