Skip to content

add undefined checker #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alibazregar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add undefined checker #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a106316
add undefined checker
alibazregar Dec 7, 2024
eb3449c
remove logs
alibazregar Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions src/component/renderable/schema/SchemaComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ export default class SchemaComponent extends SourceBaseComponent {
var schemaCallback: GetSchemaCallbackAsync = schemaCallbackStr
? eval(schemaCallbackStr)
: null;

if (!schemaCallback) {
schemaCallback = async (context, schemaUrl) => {
// const url = Util.formatUrl(schemaUrlStr, null, {
Expand Down Expand Up @@ -214,8 +213,8 @@ export default class SchemaComponent extends SourceBaseComponent {
this._schema = await schemaCallback(this.context, options.paramUrl);
const optionName = await this.getAttributeValueAsync("options");
let option = optionName ? eval(optionName) : null;
const validationHandler = new ValidationHandler(this._schema.lid, option);
const schemaDirection = this._schema.direction ?? direction;
const validationHandler = new ValidationHandler(this._schema?.lid, option);
const schemaDirection = this._schema?.direction ?? direction;
options["direction"] = schemaDirection;
container.setAttribute("data-bc-schema-direction", schemaDirection);
const sections = new Map<number, Section>();
Expand Down Expand Up @@ -267,7 +266,7 @@ export default class SchemaComponent extends SourceBaseComponent {
options,
cellManager,
partAnswer,
validationHandler
validationHandler
)
);
}
Expand All @@ -294,7 +293,7 @@ validationHandler
let hasValidationError = false;
let retVal: IUserActionResult = null;
const errorResultSourceId =
await this.errorResultSourceIdToken?.getValueAsync();
await this.errorResultSourceIdToken?.getValueAsync();
for (const question of this._questions) {
try {
var actions = await question.getUserActionAsync();
Expand Down