432 new feature willard chandler density parameter #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid file name causes cloning to fail on Windows.
|
@a-ws-m could you do your changes on this PR? If you don't have time let me know, I can take care. Thanks! |
|
@Marcello-Sega I'm away for a week but I can do them when I'm back :) |
|
No worries, then I'll take care of it. |
|
I've decided to add a a surface layer identification mechanism for the Willard Chandler method, I will include the docstring test in that pull request linked to #434 |
Marcello-Sega
deleted the
432-new-feature-willard-chandler-density-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Willard Chandler method takes a parameter c that defines the density to use to describe the isosurface. In Pytim, this defaults to the average of the minimum and maximum density. However, sometimes one might want to use a different value, so I've just added an argument to the
WillardChandlerclass so we can!I also deleted
.travis.yml., which you can undo if you'd like. I wasn't able to clone the repository on Windows because the file name is invalid. I suspect it should be.travis.yml(without the trailing.), so it probably needs renaming anyway.Please make sure that your pull request satisfies the following requirements:
If you have written a new method in one of the available modules
Please let me know if you want me to add another test to the docstring; it might make it a bit lengthy.