Skip to content

Conversation

@AgentHagu
Copy link
Contributor

@AgentHagu AgentHagu commented Apr 17, 2025

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:
Adds more tests to includePanelProcessor.test.ts.

Adds assertions to check the errors logged by logger using jest.spyOn

Anything you'd like to highlight/discuss:
These changes are derived from the PR #2639

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)
Add more tests for includePanelProcessor.ts


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@codecov
Copy link

codecov bot commented Apr 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.36%. Comparing base (fe2e1b9) to head (1e2fb8c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
+ Coverage   60.61%   61.36%   +0.75%     
==========================================
  Files         130      130              
  Lines        7170     7170              
  Branches     1480     1515      +35     
==========================================
+ Hits         4346     4400      +54     
+ Misses       2761     2707      -54     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AgentHagu AgentHagu marked this pull request as ready for review April 20, 2025 05:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances test coverage for includePanelProcessor.ts by adding comprehensive error scenario tests and logger verification. The changes focus on ensuring both the error output and logger calls are properly tested for various edge cases.

Key changes include:

  • Addition of logger spy assertions to existing error handling tests
  • Addition of 6 new test cases covering missing files, empty src attributes, URL validation, and cyclic references for both <include> and <popover> elements
  • Updates to the expectedErrors array to reflect all error messages that will be logged during test execution

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gerteck gerteck force-pushed the add-includePanelProcessor-tests branch from c048ee5 to 1e2fb8c Compare December 15, 2025 18:50
Copy link
Member

@gerteck gerteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerteck gerteck merged commit affb8e3 into MarkBind:master Dec 15, 2025
10 checks passed
@github-actions github-actions bot added the r.Patch Version resolver: increment by 0.0.1 label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants