Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stack_root to environment #484

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

pretendWhale
Copy link
Contributor

@pretendWhale pretendWhale commented Jan 30, 2024

adds STACK_ROOT to the environment, which specifies the location for the .stack directory for the global stack install. By default this goes to the root of the workspace directory, which I think is sensible for production as well.

Note: testing requires a rebuild of the autotester environment and running a haskelltest - after that, you should see a .stack location in the workspace root

@pretendWhale pretendWhale marked this pull request as draft January 30, 2024 20:36
@pretendWhale pretendWhale marked this pull request as ready for review February 6, 2024 15:26
@pretendWhale pretendWhale added this to the v2.4.1 milestone Feb 6, 2024
Copy link
Contributor

@donny-wong donny-wong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add to changelog, and instructions to Readme as to why we put it in the root.

@david-yz-liu david-yz-liu merged commit 566bf7c into MarkUsProject:master Feb 7, 2024
13 checks passed
donny-wong pushed a commit to donny-wong/markus-autotesting that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants