Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically, since this was originally MMU2 stuff, I've updated to the correct MMU3 stuff
MSG_
|TITLE_
, andDESC_
- language_en.hNote
Originally, this code was taken from prusa3d/Prusa-Firmware/tree/MK3/Firmware/mmu2 + files included from the previous Firmware directory, updated last by #26635 as to work with MMU3.
However, this repo has support for MMU2S
The two share a common firmware - in their Releases, one asset is
MMU2S_MMU3_FW3.0.3+896.hex
and from the README file:
Maybe @eoyilmaz or @thinkyhead or someone else can review this,
but perhaps
HAS_PRUSA_MMU2S
is closer related toHAS_PRUSA_MMU3
- I mean according to @prusa3d thats what it seems likeFurthermore
I am unsure of a few things, such as the ButtonOperations
According to prusa3d/Prusa-Error-Codes, there has been some removed from
enum class ButtonOperations
in button_operations.h . Things likeSkip
was added, andMoreInfo
removed. So I'm not so sure how to deal with this in the remaining files. I leftMoreInfo
, because some things do use it, I just dont know how or if it (still) works for the printer/MMU side, or was meant only for MMU2Also, in the updated mmu-error-codes.yaml, it seems button options like
Tune
and such were dropped so I'm wondering how that works on the Prusa's side.Requirements
Benefits
Configurations
Related Issues
Just wanted to point this out
not sure if this needs change, but
apparently a couple things have been declared but are unused:
two_choices
button_op_middle