Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APNG to GIF + updates and a lot of fixes #103

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

MichaelDavidGK
Copy link

  • Refactor image processing to use sharp and sharp-apng instead of jimp
  • Added APNG to GIF conversion on the go, just click on sticker
  • Made sure transparent GIFs works
  • Looped all GIFs infinitely
  • Resized GIFs to same specs
  • Some error handling, log output and comments
  • Add DLL copying for Windows builds (for sharp)
  • Update GitHub Actions workflows to use latest action versions and Node.js 22 + on workflow_dispatch

- Refactor image processing to use sharp and sharp-apng instead of jimp
- Added APNG to GIF conversion on the go, just click on sticker
- Made sure transparent GIFs works
- Looped all GIFs infinitely
- Resized GIFs to same specs
- Some error handling, log output and comments
- Add DLL copying for Windows builds (for sharp)
Copy link

socket-security bot commented Feb 25, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Possible typosquat attack npm/@electron/packager@18.3.6 ⚠︎
HTTP dependency npm/@electron/rebuild@3.7.1 ⚠︎

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

What are http dependencies?

Contains a dependency which resolves to a remote HTTP URL which could be used to inject untrusted code and reduce overall package reliability.

Publish the HTTP URL dependency to npm or a private package repository and consume it from there.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@electron/packager@18.3.6
  • @SocketSecurity ignore npm/@electron/rebuild@3.7.1

Copy link

Report too large to display inline

View full report↗︎

@MichaelDavidGK
Copy link
Author

@MarvNC let me know if you want any other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants