Open
Conversation
manixate
reviewed
Mar 22, 2026
src/OAuth.js
Outdated
| OAuth.signSignatureBaseString = function signSignatureBaseString(sbs, signingKey, signatureMethod = DEFAULT_SIGNATURE_METHOD) { | ||
| try { | ||
| signature = signer.sign(signingKey, "base64"); | ||
| const signingConfig = SignatureMethod.resolveConfig(signatureMethod) |
Member
There was a problem hiding this comment.
I would suggest to either to move this code to the other file (rename it to something like Signer) and handle the logic in there or move that code in this file but avoid but in any case avoid resolveConfig implementation
Contributor
Author
There was a problem hiding this comment.
Renamed SIgnatureMethod.js to Signer.js, moved signing to it, and updated this file to use it.
ech0s7r
reviewed
Mar 24, 2026
src/Signer.js
Outdated
| return signingConfig[method].sign(data, key) | ||
| } | ||
|
|
||
| function validate(method) { |
Member
There was a problem hiding this comment.
Suggested change
| function validate(method) { | |
| function validateSignatureMethod(method) { |
src/Signer.js
Outdated
| */ | ||
| function sign(data, key, method) { | ||
| validate(method); | ||
| return signingConfig[method].sign(data, key) |
Member
There was a problem hiding this comment.
Suggested change
| return signingConfig[method].sign(data, key) | |
| return signingConfig[method].sign(data, key); |
| }, "base64"); | ||
| } | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
Minor: new line missing.
Suggested change
| }; | |
| }; | |
joseph-neeraj
commented
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support RSA PSS